Skip to content

feat(toolbox-core): add support for bound parameters #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Mar 31, 2025

Adds basic support for "bound parameters", which is a client-side only feature that allow you to bind the value of a parameter to a value (or function that produces a value).

Makes the following changes:

  • ToollboxClient: load_tool and load_toolset now have an optional parameter bound_params
  • ToolboxTool: adds bind_parameters method

@kurtisvg kurtisvg requested a review from a team as a code owner March 31, 2025 23:04
@kurtisvg kurtisvg changed the title feat: add support for bound parameters feat(toolbox-core): add support for bound parameters Mar 31, 2025
twishabansal
twishabansal previously approved these changes Apr 1, 2025
@twishabansal twishabansal self-requested a review April 1, 2025 13:18
@twishabansal twishabansal dismissed their stale review April 1, 2025 13:19

Need to recheck

@kurtisvg kurtisvg force-pushed the kvg-bound-params branch 2 times, most recently from 27a915c to 3abe9e4 Compare April 2, 2025 02:50
@twishabansal twishabansal self-requested a review April 2, 2025 13:07
Base automatically changed from kvg-basic-auth to main April 2, 2025 19:46
@kurtisvg kurtisvg force-pushed the kvg-bound-params branch 2 times, most recently from 1fd3398 to e9e1c89 Compare April 2, 2025 20:56
@kurtisvg kurtisvg merged commit b2a2208 into main Apr 2, 2025
14 checks passed
@kurtisvg kurtisvg deleted the kvg-bound-params branch April 2, 2025 21:13
This was referenced Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants